refactor(mcp): converge runtime lifecycle ownership - #1987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MCPServerRuntimeStateinstead of exposing mutable process handles across the Services/Core boundaryArchitecture and behavior
Startedalways carries a live connection; invalid context or a missing post-start connection fails explicitlystop_server -> start_serverlifecycle, preventing stale connection-pool, ToolRegistry, catalog, or listener referencesDependency and CI impact
product-fullexpansion; owner verification uses onlybitfun-services-integrations --no-default-features --features mcpVerification
cargo test -p bitfun-services-integrations --no-default-features --features mcp --test mcp_contracts(41 passed)cargo test -p bitfun-core --lib service::mcp::server::manager::tests -- --nocapture(3 passed)cargo check -p bitfun-core --libgit diff --check gcwing/main...HEADLocal-only artifacts
The implementation spec and plan under
docs/superpowers/**remain untracked locally and are not part of this PR.